fix: knowledgebase.spec.fileGroups[*].path use path in versioneddataset #296
+22
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
force-pushed
the
newpath
branch
2 times, most recently
from
c7f9639
to
c0bb450
Compare
|
@zqq454224016 @Carrotzpc pls notice this change |
bjwswang
reviewed
Nov 28, 2023
Signed-off-by: Abirdcfly <[email protected]>
bjwswang
approved these changes
Nov 28, 2023
nkwangleiGIT
pushed a commit
to nkwangleiGIT/arcadia
that referenced
this pull request
Dec 1, 2023
fix: knowledgebase.spec.fileGroups[*].path use path in versioneddataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it
Make the meaning and content of the field
pathin CRDKnowledgebaseconsistent withCRD
Versioneddatasetto avoid ambiguityWhich issue(s) this PR fixes
Fixes #
Special notes for your reviewer