Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty is displayed when the data is empty, and the problem of the login button not responding is fixed #66

Closed
wants to merge 1 commit into from

Conversation

likaiqiang
Copy link

…he login button not responding is fixed.

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

@yunti-bot
Copy link

👍 @likaiqiang


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link
Collaborator

@Vsion Vsion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disapprove: 产品角度不应该有为空的分类, 尤其是推荐下

@likaiqiang
Copy link
Author

likaiqiang commented Mar 29, 2024

disapprove: 产品角度不应该有为空的分类, 尤其是推荐下

不太懂你们的产品想法,你们某些分类下没有数据,会显示一片白不好看。

fetch("http://localhost:3000/kubeagi-apis/bff?o=listGPTs", {
  "headers": {
    "accept": "*/*",
    "accept-language": "zh-CN,zh;q=0.9",
    "content-type": "application/json",
    "sec-ch-ua": "\"Google Chrome\";v=\"125\", \"Chromium\";v=\"125\", \"Not.A/Brand\";v=\"24\"",
    "sec-ch-ua-mobile": "?0",
    "sec-ch-ua-platform": "\"Windows\"",
    "sec-fetch-dest": "empty",
    "sec-fetch-mode": "cors",
    "sec-fetch-site": "same-origin",
    "cookie": "NEXT_LOCALE=zh; client_theme=light",
    "Referer": "http://localhost:3000/zh/agent",
    "Referrer-Policy": "strict-origin-when-cross-origin"
  },
  "body": "{\"query\":\"query listGPTs($input: ListGPTInput!) {\\n  GPT {\\n    listGPT(input: $input) {\\n      page\\n      pageSize\\n      totalCount\\n      hasNextPage\\n      nodes {\\n        ... on GPT {\\n          name\\n          displayName\\n          description\\n          hot\\n          creator\\n          category\\n          icon\\n          prologue\\n        }\\n      }\\n    }\\n  }\\n}\",\"variables\":{\"input\":{\"category\":\"推荐\",\"page\":1,\"pageSize\":-1}},\"operationName\":\"listGPTs\"}",
  "method": "POST"
}).then(res=> res.json()).then(res=>{
    console.log(res.data.GPT.listGPT.nodes)
    // 这里最后的结果是个空数组
})

@Vsion
Copy link
Collaborator

Vsion commented Mar 29, 2024

disapprove: 产品角度不应该有为空的分类, 尤其是推荐下

不太懂你们的产品想法,你们某些分类下没有数据,会显示一片白不好看。

fetch("http://localhost:3000/kubeagi-apis/bff?o=listGPTs", {
  "headers": {
    "accept": "*/*",
    "accept-language": "zh-CN,zh;q=0.9",
    "content-type": "application/json",
    "sec-ch-ua": "\"Google Chrome\";v=\"125\", \"Chromium\";v=\"125\", \"Not.A/Brand\";v=\"24\"",
    "sec-ch-ua-mobile": "?0",
    "sec-ch-ua-platform": "\"Windows\"",
    "sec-fetch-dest": "empty",
    "sec-fetch-mode": "cors",
    "sec-fetch-site": "same-origin",
    "cookie": "NEXT_LOCALE=zh; client_theme=light",
    "Referer": "http://localhost:3000/zh/agent",
    "Referrer-Policy": "strict-origin-when-cross-origin"
  },
  "body": "{\"query\":\"query listGPTs($input: ListGPTInput!) {\\n  GPT {\\n    listGPT(input: $input) {\\n      page\\n      pageSize\\n      totalCount\\n      hasNextPage\\n      nodes {\\n        ... on GPT {\\n          name\\n          displayName\\n          description\\n          hot\\n          creator\\n          category\\n          icon\\n          prologue\\n        }\\n      }\\n    }\\n  }\\n}\",\"variables\":{\"input\":{\"category\":\"推荐\",\"page\":1,\"pageSize\":-1}},\"operationName\":\"listGPTs\"}",
  "method": "POST"
}).then(res=> res.json()).then(res=>{
    console.log(res.data.GPT.listGPT.nodes)
    // 这里最后的结果是个空数组
})
  • 2C 的产品很少采用空白占位符, 内容更重要
  • 直接使用 antd Empty 与当前设计不符

@nkwangleiGIT 可以考虑丰富一下环境分类下的智能体, 尽量避免比如推荐下为空的情况

@likaiqiang
Copy link
Author

disapprove: 产品角度不应该有为空的分类, 尤其是推荐下

不太懂你们的产品想法,你们某些分类下没有数据,会显示一片白不好看。

fetch("http://localhost:3000/kubeagi-apis/bff?o=listGPTs", {
  "headers": {
    "accept": "*/*",
    "accept-language": "zh-CN,zh;q=0.9",
    "content-type": "application/json",
    "sec-ch-ua": "\"Google Chrome\";v=\"125\", \"Chromium\";v=\"125\", \"Not.A/Brand\";v=\"24\"",
    "sec-ch-ua-mobile": "?0",
    "sec-ch-ua-platform": "\"Windows\"",
    "sec-fetch-dest": "empty",
    "sec-fetch-mode": "cors",
    "sec-fetch-site": "same-origin",
    "cookie": "NEXT_LOCALE=zh; client_theme=light",
    "Referer": "http://localhost:3000/zh/agent",
    "Referrer-Policy": "strict-origin-when-cross-origin"
  },
  "body": "{\"query\":\"query listGPTs($input: ListGPTInput!) {\\n  GPT {\\n    listGPT(input: $input) {\\n      page\\n      pageSize\\n      totalCount\\n      hasNextPage\\n      nodes {\\n        ... on GPT {\\n          name\\n          displayName\\n          description\\n          hot\\n          creator\\n          category\\n          icon\\n          prologue\\n        }\\n      }\\n    }\\n  }\\n}\",\"variables\":{\"input\":{\"category\":\"推荐\",\"page\":1,\"pageSize\":-1}},\"operationName\":\"listGPTs\"}",
  "method": "POST"
}).then(res=> res.json()).then(res=>{
    console.log(res.data.GPT.listGPT.nodes)
    // 这里最后的结果是个空数组
})
  • 2C 的产品很少采用空白占位符, 内容更重要
  • 直接使用 antd Empty 与当前设计不符

@nkwangleiGIT 可以考虑丰富一下环境分类下的智能体, 尽量避免比如推荐下为空的情况

明白你的意思,但我自己并不是很懂设计,能提供一下你们当前的设计吗?一张截图即可

@Carrotzpc
Copy link
Collaborator

Carrotzpc commented Apr 9, 2024

fixed in #80

@Carrotzpc Carrotzpc closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants