-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aggregated ClusterRole to manage namespaced resources #1399
Conversation
Thanks for the proposal and for the implementation! However I would like to separate these clusterroles based on the following resources:
I'm not sure about the eventtailer, since that is something to be installed once into a logging system, not something to manage by individual users. Also I would create a viewer role, that doesn't have to be split by resources, just grant view privileges to all the above logging resources for users. I'm still a bit sceptical that we can provide clusterroles that are useful for most users/use cases, but at least we can provide an example implementation. |
@pepov Rancher has this implementation also for read-only/view access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would either name the clusterrole as "-edit" and add aggregator label for editor as well as in these examples:
- https://kubernetes.io/docs/reference/access-authn-authz/rbac/#aggregated-clusterroles
- https://github.com/cert-manager/cert-manager/blob/cabc05824abbf033440b56d25c914701610d528f/deploy/charts/cert-manager/templates/rbac.yaml#L432
Or if we want to follow the rancher example then use the suffix '-admin' instead of user.
Signed-off-by: Zadkiel Aharonian <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
add notice to logging status when there are multiple logging resources with the same ref Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
Co-authored-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
Co-authored-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]> Co-authored-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
Signed-off-by: Zadkiel Aharonian <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
… invalid Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
…g aggregator mode as well Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
fixes #1398