Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc, default values and kube.tf with recent changes to cluster_autoscaler_version, initial_k3s_channel and var sys_upgrade_controller_version #1534

Conversation

janfrederik
Copy link
Contributor

@janfrederik janfrederik commented Nov 7, 2024

#1512 introduced a new var sys_upgrade_controller_version.

  • Corrected the description, which was an incorrect copy-paste from another var.
  • Added the var to kube.tf.example

#1506 reverted cluster-autoscaler back to the community version. However, the default version for var cluster_autoscaler_version (1.31.1), does not correspond to the new default initial_k3s_channel ("stable", which is currently still 1.30) and the doc says these versions should correspond. So I put version 1.30.3 as default. This is in line with the initial_k3s_channel and includes the patch for the Hetzner deprecation of CX11.

Added csi_driver_smb_version to kube.tf.example

Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janfrederik, appreciate this very much.

@mysticaltech mysticaltech merged commit a83dc0a into kube-hetzner:master Nov 7, 2024
3 checks passed
@janfrederik janfrederik deleted the doc/sys_upgrade_controller_version branch November 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants