Add automatic install script for Linux #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba2k2
requested changes
Jul 24, 2024
README.md
Outdated
| @@ -24,6 +24,12 @@ The .exe file is an installer - just open it and install the native application. | |||
|
|
|||
| ### Installation on Linux | |||
|
|
|||
| Run script: | |||
|
|
|||
| `wget -O - https://raw.githubusercontent.com/Virusmater/firefox-webserial/master/install.sh | bash` | |||
There was a problem hiding this comment.
Is is possible to use curl for this? It is more likely to have curl installed by default on a Linux distro than wget. Also curl is used anyway in the .sh script.
The URL has to be adjusted to point to the original repo 😄
install.sh
Outdated
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
A better place for this file would be native/install/linux_x86_64.sh.
…dir, use cURL to download the script
kuba2k2
approved these changes
Jul 26, 2024
kuba2k2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, I know it is not always secure, but it helps install on multiple machines.
If merged will be required to change README path from my repo to the main one.