Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor using cohesion-tools package #186

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Refactor using cohesion-tools package #186

merged 6 commits into from
Jul 28, 2023

Conversation

nobu-g
Copy link
Member

@nobu-g nobu-g commented Jul 28, 2023

What

I've separated cohesion-analysis-related codes into another package called cohesion-tools.
This PR reflects the change above.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #186 (f8c5945) into dev (c8a302b) will increase coverage by 0.17%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##              dev     #186      +/-   ##
==========================================
+ Coverage   90.54%   90.71%   +0.17%     
==========================================
  Files          63       62       -1     
  Lines        5352     4891     -461     
==========================================
- Hits         4846     4437     -409     
+ Misses        506      454      -52     
Files Changed Coverage Δ
src/kwja/callbacks/word_module_writer.py 89.10% <ø> (ø)
src/kwja/utils/cohesion_analysis.py 86.27% <81.81%> (+1.70%) ⬆️
src/kwja/callbacks/utils.py 98.67% <100.00%> (+2.30%) ⬆️
src/kwja/datamodule/datasets/word.py 93.26% <100.00%> (+0.27%) ⬆️
src/kwja/datamodule/datasets/word_inference.py 96.00% <100.00%> (+0.71%) ⬆️
src/kwja/datamodule/examples/word.py 98.27% <100.00%> (+0.03%) ⬆️
src/kwja/metrics/word.py 99.00% <100.00%> (+0.68%) ⬆️
src/kwja/modules/word.py 99.33% <100.00%> (-0.01%) ⬇️

@nobu-g nobu-g merged commit d38a24e into dev Jul 28, 2023
52 checks passed
@nobu-g nobu-g deleted the with-cohesion-tools branch July 28, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant