Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a precompile workload #7

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

jlapeyre
Copy link
Contributor

On my laptop, the first execution time of the example in the README after this commit is 2.3s.

The first execution time before this commit is 10.0s.

On my laptop, the first execution time of the example in the README after this
commit is 2.3s.

The first execution time before this commit is 10.0s.
Copy link
Owner

@kshyatt-aws kshyatt-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I actually have a much larger set of precompile statements I hope to add in the very near future so some of this may end up superseded, but no reason not to merge it now.

@kshyatt-aws
Copy link
Owner

FWIW on my M2 the README with no precompile statements runs in 4s, not 10s.

@kshyatt-aws kshyatt-aws merged commit 91e6a42 into kshyatt-aws:main Oct 31, 2024
4 checks passed
@jlapeyre
Copy link
Contributor Author

I meant to put version info in the comment, but neglected to. The timing was under Julia 1.11.0
on a Ryzen 7 PRO 8840HS.

The ratio of 10s to 4s is surprising.

I guess that all the re-compilation that happens even with the precompilation is related the computation in __init__. I wouldn't be surprised if you have some tricks to get around it. Anyway, committing this now might make this more ergonomic for people trying it out.

@kshyatt-aws
Copy link
Owner

Yeah, agreed re: trying it out. I'll make a PR with more precompile workloads soon. Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants