Merge pull request #12 from kronostechnologies/DOPS-3905/mysqldump_slow

Improve performance: Increase default max_allowed_packet
kronostechnologies · Oct 23, 2023 · 43ab8fa · 43ab8fa
2 parents faf7525 + 2a97b1a
commit 43ab8fa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,12 +1,10 @@
-FROM node:14 AS builder
-MAINTAINER "[email protected]"
+FROM node:18 AS builder
 
 WORKDIR /code
 COPY ["package.json", ".yarnclean", "yarn.lock", "/code/"]
 RUN yarn install && yarn autoclean --force && yarn cache clean
 
-
-FROM node:14-slim
+FROM node:18-slim
 
 COPY --from=builder /code /code
 WORKDIR /code

diff --git a/mysql2s3.js b/mysql2s3.js
@@ -34,7 +34,7 @@ const config = {
 			host: process.env.MYSQL_HOST,
 			user: process.env.MYSQL_USER,
 			password: process.env.MYSQL_PWD,
-			max_allowed_packet: process.env.MAX_ALLOWED_PACKET || "4194304",
+			max_allowed_packet: process.env.MAX_ALLOWED_PACKET || "256000000",
 		},
 		s3: {
 			bucket: process.env.AWS_S3_BUCKET,
@@ -307,6 +307,7 @@ const _getMySqlDump = (config) => {
 			'-u', config.user,
 			'--single-transaction',
 			'--max_allowed_packet', config.max_allowed_packet,
+			'--skip-lock-tables',
 			config.database
 		],
 		{