feat(Table): rows grouping #1003
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savutsang
force-pushed
the
dev/DS-915
branch
3 times, most recently
from
613185c
to
12e6764
Compare
savutsang
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Storybook for this build: https://ds.equisoft.io/pr-1003/ |
savutsang
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Webapp for this build: https://ds.equisoft.io/pr-1003/webapp/ |
savutsang
force-pushed
the
dev/DS-915
branch
2 times, most recently
from
090a905
to
5c2120d
Compare
savutsang
temporarily deployed
to
github-pages
GitHub Actions
Inactive
savutsang
temporarily deployed
to
github-pages
GitHub Actions
Inactive
savutsang
commented
Oct 11, 2024
There was a problem hiding this comment.
J'ai des erreurs de Typescript que j'arrive pas a resoudre, plus j'essaie de fixer ca et plus je recule. Le probleme est essentiellement l'incompatibilite des types generics, l'erreur est visbile dans data-table.stories.tsx. J'aurais besoin de cerveau frais qui pourrais m'aider a resooudre ca.
savutsang
commented
Oct 11, 2024
| @@ -136,7 +136,7 @@ export const WithFooter: Story = () => { | |||
|
|
|||
| // Footer function for the 'numbers' column | |||
| const footerSum = (): ReactElement => { | |||
| const total = data.reduce((sum, row) => row.numbers + sum, 0); | |||
| const total = (data as FooterData[]).reduce((sum, row) => row.numbers + sum, 0); | |||
There was a problem hiding this comment.
J'aimerais mieux qu'on ai pas a caster ici, ni les autres casting plus bas non plus
savutsang
temporarily deployed
to
github-pages
GitHub Actions
Inactive
savutsang
temporarily deployed
to
github-pages
GitHub Actions
Inactive
maboilard
requested changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permettre d'afficher des rows sous des groups
Note: Les screenshots dans JIRA ont des background gris, mais c'est plutot blanche/transparent tel que dans Figma.