This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: update account and paymaster validation return format #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangsorang
reviewed
Aug 26, 2024
| (bytes32(MAGIC_VALUE_SENDER) | | ||
| bytes32(uint256(validUntil) << (6 * 8)) | | ||
| bytes32(uint256(validAfter))); | ||
| uint48 validUntil = 0; |
There was a problem hiding this comment.
I was wondering why you set the until value to 0?
There was a problem hiding this comment.
If both values of validUntil and validAfter are 0, it will be recognized as [0, type(uint48).max] automatically at validateValidityTimeRange function in geth.
There was a problem hiding this comment.
Oh, right.
Passing validUntil = 0 and validAfter = 0 in the specification disables the check. So this part applies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the return data format of
validateTransactionatTestAccount.solandvalidatePaymasterTransactionatTestPaymaster.solto fit to the changes at geth.