Revert #725 - Registering customLabel macro once Form resolved #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangnguyenplus
changed the title
|
Works for me with Laravel 9 on PHP 8.2. Original PR tested Laravel 9 on PHP 8.0, that worked too: https://github.com/kristijanhusak/laravel-form-builder/actions/runs/8547107396/job/23418677886?pr=725 What seems to be going wrong? Any idea? I like the smarter boot, I don't want to revert it without a good specific known reason. |
|
@rudiedirkx I have no idea, if it is fine for you then we may keep it. Maybe it has something wrong with their code, not an issue of this package. |
|
If you get more details or reports, add them here. Maybe our tests just aren't good enough, but the |
|
@sangnguyenplus 1.53.1 probably fixes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#725
@rudiedirkx It is working fine in our latest code with Laravel 10, but I got some reports that it doesn't work for old versions (which using Laravel 9).
I think this is a breaking change, we should not change this at this time.
Please revert it.