Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit role credential TTL to 1 hour (AWS default) #28

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Limit role credential TTL to 1 hour (AWS default) #28

merged 3 commits into from
Jun 26, 2018

Conversation

brotbert
Copy link
Member

@brotbert brotbert commented Jun 11, 2018 •
edited
Loading

@brotbert brotbert requested a review from yawn June 11, 2018 15:39
@brotbert
Copy link
Member Author

@yawn May I merge it?

yawn
yawn approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@yawn yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yawn
Copy link
Contributor

yawn commented Jun 26, 2018

Let's merge it but defer the release. I'd like to get #22 and #20 (plus some) in there as well.

@brotbert brotbert merged commit 70c1ccf into master Jun 26, 2018
@brotbert brotbert deleted the bugfix/role-ttl branch June 26, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawn yawn yawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brotbert @yawn