Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maquette-v3.0.1-keyed #271

Closed
wants to merge 1 commit into from
Closed

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Nov 1, 2017

addresses #270

I did a pretty straightforward port of domvm. considering that the only optimization is event delegation, it performs pretty well. i couldn't find a way to make maquette swallow a non-keyed impl; it bitches at runtime about needing keys when it detects similar sibling nodes.

this impl may need slight tweaking, since i just took the UMD build and dumped it into /src. i added it to package.json but didnt bother working out exactly how to require/import it from there.

maquette-keyed

@leeoniya leeoniya mentioned this pull request Nov 2, 2017
@krausest
Copy link
Owner

krausest commented Nov 8, 2017

Sorry - I'm getting an exception when clicking "create 1,000 rows":
Uncaught ReferenceError: getProjection is not defined
at HTMLButtonElement. (bundle.js:1)
Any idea how to fix it?

@leeoniya
Copy link
Contributor Author

leeoniya commented Nov 8, 2017

@johan-gorter

By the way, I somehow had to disable uglify in build.js, because it created errors at runtime (getProjection was undefined).

#270 (comment)

@johan-gorter
Copy link
Contributor

One more remark about this pull request, could you please include maquette from node_modules instead of the copy that is inlined. This will enable me to try out new approaches using npm link. @leeoniya will you update this pull request or shall I start my own?

@leeoniya
Copy link
Contributor Author

leeoniya commented Nov 9, 2017

yeah, just make a new pr. i'll close this one rather than having to maintain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants