-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation: update heap index translation #1620
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas
thanks for the hard work!
below are just my personal opinion/suggestion.
kind regards
en/docs/chapter_heap/index.md
Outdated
|
||
Among these peaks, the highest one always catches the eye first. | ||
The peaks are arranged at various heights, but the highest peak always catches the eye first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas
I felt like the original version may be better with a slight tune:
"Heaps are like towering mountain peaks, stacked and undulating, each with its own unique shape.
Among these peaks, the tallest one always captures attention first."
reasons:
yes the refined version is good, however I felt like it kinda break the imagery a bit, for example "山峰" (peak) suggest unique shape and height, which aligns with the metaphor of heaps (where heap is distinct part of the structure).
"mountain ranges" may change the metaphor slightly. Mountain ranges suggest a collective form rather than distinct peaks, diminishing the emphasis on individuality. The CN version is quite visual and poetic, this change may make it more neutral and less vivid.
(also rather changing "the eye first." -> "captures attention first." is OPTIONAL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @K3v123 for your detailed suggestions. I've adopted some of your suggestions.
- add "their jagged peaks" to include the peaks.
- I prefer using "form" over "shape" as the former is three-dimensional.
- "Among these peaks" misses some details from its Chinese version "座座山峰高低错落", hence I replace it with a complete sentence to reflect the meaning.
@@ -4,6 +4,6 @@ | |||
|
|||
!!! abstract | |||
|
|||
The heap is like mountain peaks, stacked and undulating, each with its unique shape. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is like" => "resemble", and "stacked" => "layered".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears to me that you were commenting on original translation instead of PR changes. Can you please review the new commit? IMO, "resemble" may not be accurate as it suggests similarity on appearance rather than internal qualities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I commented directly on the original version because of the previous comment "I felt like the original version may be better with a slight tune".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears to me that you were commenting on original translation instead of PR changes. Can you please review the new commit? IMO, "resemble" may not be accurate as it suggests similarity on appearance rather than internal qualities.
Hi, Thomas. I still insist on "resemble", as it refers to both physical appearance and inherent characteristics, and it's more formal than "be like".
|
||
Among these peaks, the highest one always catches the eye first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "高低错落" has not been shown in the translation. Maybe it could be translated into "rise and fall in a staggered arrangement"
- Ich denke, this context is about progressive explanation, not contrast. So "and" is more suitable than "but".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. thanks for your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect! again thanks for the hard work!
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: