Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python-dotenv so native interpolation works #36

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

lgtml
Copy link
Contributor

@lgtml lgtml commented Aug 1, 2024

Thanks for Jinjanator super handy!

I wanted to suggest using the python-dotenv module so that it can match the documented interpolation and behavior. I ran into issues when I was expecting one behavior and got the other.

example.

CLOUD_REGION=ca-central-1
CLOUD_RESOURCE=meow
CLOUD_URL=${CLOUD_RESOURCE}-${CLOUD_REGION}.cloud.cloud

src/jinjanator/formats.py Outdated Show resolved Hide resolved
src/jinjanator/formats.py Outdated Show resolved Hide resolved
@lgtml lgtml requested a review from kpfleming August 2, 2024 13:47
Copy link
Owner

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just some tiny comment fixes to apply!

Ignore the CI failure; the CI in this repository doesn't work for non-maintainers if the PR includes changes to the project dependencies.

tests/test_env.py Outdated Show resolved Hide resolved
tests/test_env.py Outdated Show resolved Hide resolved
@lgtml
Copy link
Contributor Author

lgtml commented Aug 3, 2024

I should have caught those! Thank you @kpfleming All updated and rebase'd

@kpfleming
Copy link
Owner

Great! I'll add a changelog entry to your branch and then get this merged.

@kpfleming kpfleming merged commit 757f73d into kpfleming:main Aug 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants