Avoid doing lookup in map twice.

kpeeters · Nov 7, 2024 · 7720402 · 7720402
1 parent 21a44e6
commit 7720402
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/algorithms/substitute.cc b/core/algorithms/substitute.cc
@@ -507,15 +507,16 @@ bool substitute::Rules::is_present(Ex& rules) const
 
 	try {
 		std::weak_ptr<Ex> rules_ptr = rules.shared_from_this();
-		bool rule_found = (properties.find(rules_ptr) != properties.end());
+		auto rule_it = properties.find(rules_ptr);
+		bool rule_found = (rule_it != properties.end());
 		if (!rule_found) return false;
 
 		// rules should have l_checkpointed set
 		bool rule_unchanged = (rules.state() == result_t::l_cached);
 
 		// If rule has been changed, erase  it.
 		if (!rule_unchanged) {
-			properties.erase(rules_ptr);
+			properties.erase(rules_it);
 			return false;
 			} 
 		else {