Add support for summoning GHC 9.2.8, 9.4.8, and 9.6.6

[noughtmare]

I've also updated the latest Stackage snapshots of 8.10.7 and 9.0.2.

[noughtmare]

@willbasky I've implemented your suggestion, thanks.

@vrom911 can you please review this?

[willbasky]

@noughtmare The tests need the updates.

[noughtmare]

I've used gg to update the golden tests.

[willbasky]

What a nice tool!

[noughtmare]

It seems the CI also needed updating.

[noughtmare]

Oh, of course summoner itself doesn't build on 9.6.2

[noughtmare]

And that's blocked on shellmet, at least.

[willbasky]

Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.6.2.0 supports 'ghc' version < 9.4): /home/runner/.ghcup/bin/ghc is version 9.6.2

< 9.4 yes, building summoner with 9.4.5 and 9.6.2 has no ways right now.

Also, instead of 9.2.4 we could build on 9.2.8

[noughtmare]

But if we can't build on 9.4.5 and 9.6.2 then we also can't test if summoning those versions work, except perhaps if we would build summoner with a different version of GHC than what we use to test the summoned project.

[willbasky]

Do the golden tests check if the 'project that is made with specific ghc in configs' is built with that ghc?
In other words:

1. Summoner makes project with ghc version X.
2. Tests tried to build made project.
   Is it?

[noughtmare]

I think you're right that the tests only check things like 1, but then I don't understand why it did not work before I changed the CI. I'll revert that and we can try again.

[noughtmare]

Neat, the old results are still here.

Ah, so it's actually a separate CI action that tries to build the minimal project.

[willbasky]

If checks within 9.6.2 will pass then we could left checks for 9.4.5 too

[noughtmare]

I've now added 9.4.5 too

[noughtmare]

Now it should work...

[noughtmare]

I've squashed the commits

[willbasky]

https://discourse.haskell.org/t/ghc-9-4-6-is-now-available/7231
I am sorry :))

[noughtmare]

@willbasky there will be a 9.4.7 soon, so I think we should skip 9.4.6.

[Vekhir]

Hi, GHC 9.4.7 is now available, and slated to be the final release of the 9.4 series. Anything blocking this from merging?

[Vekhir]

@kowainik @vrom911 @noughtmare @willbasky What is the plan to proceed with this PR to enable summoner to support GHC 9.2, 9.4, and 9.6?
GHC 9.4.7 has been released, together with a new release 9.6.3.

A new version of summoner on Hackage would also be much appreciated, as it's needed for the Arch package

[noughtmare]

@Vekhir I think this package has been abandoned. I'm personally not motivated enough to fork and initiate the package takeover process. So I think not much is going to change any time soon.

[Vekhir]

Alright, thanks for your reply.

[willbasky]

@Vekhir Hi, I tried to message to @vrom911 in social media she didn't answer. As for me I haven't the right to merge here anything without second approval I guess. I am sorry.

[tomjaguarpaw]

I am a kowainik assistant maintainer and I can merge this. However, could you please first explain why some of the steps have been disabled for 9.4.5 and 9.6.2?

[Vekhir]

@tomjaguarpaw Not OP, but see this comment here: #570 (comment)

Also see the summoner.cabal:

summoner/summoner-cli/summoner.cabal

Line 77 in 30b5604

build-depends: base >= 4.11 && < 4.17

and summoner-tui.cabal:

summoner/summoner-tui/summoner-tui.cabal

Line 31 in 30b5604

build-depends: base >= 4.11 && < 4.17

In essence, summoner doesn't build with 9.4 and 9.6 due to too restrictive base (<4.17). It can still summon them, just doesn't build with them. 9.4 can probably be just bumped, but 9.6 has a compile issue: #575

[tomjaguarpaw]

OK, let's fix summoner first to build with 9.4 and 9.6 rather than adding these special cases.

[noughtmare]

Yeah, @Vekhir is right. At least at the time some of summoner's dependencies were not updated yet to those GHC versions.

@tomjaguarpaw do you want me to try building it again (and I could add some newer GHC versions while I'm at it)? Or do we want to merge this first and fix the other things later?

[tomjaguarpaw]

I'll get summoner building on the latest GHCs, and when that's done you can rebase this MR on top (hopefully without special cases).

[tomjaguarpaw]

OK, main now builds on up to 9.6. Could you please rebase your branch and remove the special cases?

[noughtmare]

I've rebased and changed 9.4.5 to 9.4.8 and 9.6.2 to 9.6.6 with the latest stackage lts.

[noughtmare]

Oh, now the golden tests have changed again

[noughtmare]

Now it might work. There are still two things that could be updated:

• the tested-with fields in summoner-cli and summoner-tui themselves
• the stack version in the stack ci job

[tomjaguarpaw]

Cool, thanks! If you feel like making the other updates then please do, but for things like tested-with I find them too difficult to keep up to date if they're not checked by tooling.

[tomjaguarpaw]

Feel free to create another PR with the updates above.

@noughtmare @willbasky @Vekhir thanks for pushing this through!

[Vekhir]

@tomjaguarpaw Thanks for merging! Quick question: Do you also have the permissions to push Hackage releases? That would be quite useful in combination with this PR.

[tomjaguarpaw]

I've asked Veronika and she says she can give me Hackage permissions in a couple of weeks.

[Vekhir]

Alright.