Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#104] Support PolymorphicComponents as language pragma #105

Merged

Conversation

jan-christiansen
Copy link
Contributor

Resolves #104

@tomjaguarpaw
Copy link
Collaborator

Thanks!

extensions.cabal Outdated Show resolved Hide resolved
@tomjaguarpaw
Copy link
Collaborator

Sorry, I made the wrong suggestion in my review comment. version needs to be reinstated, with the original version number.

@jan-christiansen
Copy link
Contributor Author

I should probably have caught that.

Are there any guidelines on history rewriting in pull requests in this projects? That is, do you squash the pull request anyway, should I use force push to combine the commits into a single commit? Do you want to keep the history of the pull request?

@tomjaguarpaw
Copy link
Collaborator

That's no problem. Personally I prefer well-curated commits, which in this case means a squash (since it's so small). I don't mind if you do that or I do that.

@tomjaguarpaw tomjaguarpaw merged commit f56be07 into kowainik:main Dec 16, 2024
8 checks passed
@tomjaguarpaw
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PolymorphicComponents
2 participants