Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace netcat with socat for liveness probe/metrics #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace netcat with socat for liveness probe/metrics #22

wants to merge 1 commit into from

Commits on Nov 27, 2019

  1. replace netcat with socat for liveness probe/metrics 

    We've had an issue on Google Kubernetes Engine, on a node with
kernel version 4.14.138+, where liveness probes would regularly fail
some percentage of the time.

We've traced the problem down to the `poll()` system call sometimes
failing in the `nc` command used in the liveness probe, whereupon
`nc` returns an empty response, despite the TCP connection from
Zookeeper clearly sending back an `imok`.

Netcat uses `select()`, `poll()`, `read()`, where `poll()` sometimes
throws an error because Zookeeper has closed the TCP connection.
Socat uses `select()`, `read()`, which works here.
    MADL David committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    8c7fd0d View commit details
    Browse the repository at this point in the history