Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KWoC mailing templates and Corresponding Changes #7

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

proffapt
Copy link
Member

@proffapt proffapt commented Nov 29, 2023

Refer the following points to add them according to the convention set for templates:

TODO

We send the following mails during KWoC, hence templates in templates are required to created.

  • KWoC intro seminar publicity
  • Invite Projects
  • To previous participants, that KWoC is back
  • Project Status mail
    • Rejected and why
    • Accepted
  • Coding Period has started
  • Mid evals deadline reminder
  • Mid evals
    • Qualified
    • Disqualified
  • End evals deadline reminder
  • End evals
    • Disqualified
    • Mail with certificates' link to qualified contributors
    • Top Contributor with their swag details, if any, and certificate link - try to add a template, but this mail is highly probable to change every year..

And following changes in general:

  • Try inverting text colors
  • Encode bg image in base64 to avoid image fetching from external source
  • Use image as background rather than img tag to avoid image interaction in email

@pep8speaks
Copy link

pep8speaks commented Nov 29, 2023

Hello @proffapt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 16:80: E501 line too long (125 > 79 characters)
Line 18:80: E501 line too long (95 > 79 characters)
Line 20:80: E501 line too long (98 > 79 characters)
Line 52:62: E261 at least two spaces before inline comment
Line 52:80: E501 line too long (125 > 79 characters)
Line 53:80: E501 line too long (95 > 79 characters)
Line 59:1: E302 expected 2 blank lines, found 1
Line 73:1: E302 expected 2 blank lines, found 1
Line 127:1: W293 blank line contains whitespace
Line 141:1: W293 blank line contains whitespace
Line 144:80: E501 line too long (103 > 79 characters)
Line 157:1: W293 blank line contains whitespace
Line 161:22: W291 trailing whitespace
Line 163:80: E501 line too long (83 > 79 characters)
Line 166:1: W293 blank line contains whitespace
Line 173:18: W291 trailing whitespace
Line 175:80: E501 line too long (117 > 79 characters)

Line 9:80: E501 line too long (129 > 79 characters)

Comment last updated at 2024-11-06 17:19:40 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants