Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kooldev/bash usage as we are now only on mac/linux #493

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

fabriciojs
Copy link
Member

Issue -
🧰 Improvement Yes
📝 Refactor Yes
📖 Documentation Yes
⚠️ Break Change No

Description

Drop relying on kooldev/bash as we no longer support Windows natively.

@fabriciojs fabriciojs requested a review from dbpolito January 6, 2024 21:34
@github-actions github-actions bot added release-drafter:changed Release drafter: Changed release-drafter:documentation Release drafter: Documentation release-drafter:minor Release drafter: Minor release-drafter:patch Release drafter: Patch labels Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c81342a) 70.53% compared to head (862fddb) 70.53%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   70.53%   70.53%           
=======================================
  Files          76       76           
  Lines        3024     3024           
=======================================
  Hits         2133     2133           
  Misses        826      826           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit a65fdd9 into main Jan 7, 2024
10 checks passed
@fabriciojs fabriciojs deleted the windows-leftover branch January 7, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-drafter:changed Release drafter: Changed release-drafter:documentation Release drafter: Documentation release-drafter:minor Release drafter: Minor release-drafter:patch Release drafter: Patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants