Android/UI/#112 #117
Open
Android/UI/#112 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmj-99
reviewed
May 7, 2024
Comment on lines
+90
to
+109
| class CustomOnlyTitleCheckViewModel @Inject constructor() : ViewModel(){ | ||
| val CustomOnlyTitleCheckDialogState : MutableState<CustomOnlyTitleCheckDialogState> = | ||
| mutableStateOf<CustomOnlyTitleCheckDialogState>( | ||
| CustomOnlyTitleCheckDialogState() | ||
| ) | ||
| fun showCustomOnlyTitleCheckDialog(){ | ||
| CustomOnlyTitleCheckDialogState.value = CustomOnlyTitleCheckDialogState( | ||
| title = "정말 로그아웃 하시나요?", | ||
| checkleft = "네", | ||
| checkright = "아니요", | ||
| onClickleft = { }, | ||
| onClickright = { resetDialogState() }, | ||
| ) | ||
| } | ||
|
|
||
| fun resetDialogState() { | ||
| CustomOnlyTitleCheckDialogState.value = CustomOnlyTitleCheckDialogState() | ||
| } | ||
| } |
There was a problem hiding this comment.
- 다이얼로그를 ViewModel로 처리하는 이유가 무엇인지 궁금합니다! 단순하게 다이얼로그를 띄우는데 ViewModel를 사용하는 것은 ViewModel의 역할과 맞지 않고 오버헤드로 보입니다!
- @Inject constructor()를 통해서 생성자 주입을 하고있는데 아무것도 주입을 안하고 있는데 주입 어노테이션을 쓴 이유가 무엇인가요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting ui 수정