✨ Added a summary of issues indicating that the analysis was successful #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvoraShechter1
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
DvoraShechter1
force-pushed
the
issues-summary
branch
from
8ee1b9b
to
1691a96
Compare
Signed-off-by: DvoraShechter1 <[email protected]>
DvoraShechter1
force-pushed
the
issues-summary
branch
from
1691a96
to
97c8e8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
==========================================
+ Coverage 39.20% 41.98% +2.78%
==========================================
Files 146 175 +29
Lines 4857 5630 +773
Branches 1164 1395 +231
==========================================
+ Hits 1904 2364 +460
- Misses 2939 3145 +206
- Partials 14 121 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
requested changes
Oct 30, 2024
| @@ -182,6 +185,19 @@ const TabDetailsContent: React.FC<{ | |||
| .filter((fullArchetype) => fullArchetype?.review) | |||
| .filter(Boolean); | |||
|
|
|||
| const issueReportsQuery = useFetchIssueReports(application.id); | |||
There was a problem hiding this comment.
This query returns a lot just to grab a count. Future improvements here to get a better counting endpoint from the hub backend services.
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: DvoraShechter1 <[email protected]>
…ckle2-ui into issues-summary
Signed-off-by: DvoraShechter1 <[email protected]>
Signed-off-by: DvoraShechter1 <[email protected]>
Signed-off-by: DvoraShechter1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information in the app details:
issues summary i.e. " X critical, Y minor" or "Congratulations! No issues were found "
part 3 of #2012