🌱 Upgrade to Patternfly 5.2 #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2024
sjd78
force-pushed
the
bump-pf-versions
branch
from
c7de0f4
to
a3c04c8
Compare
|
Note: patternfly-react issue patternfly/patternfly-react#10064 needs to be resolved BEFORE this PR can be merged. The PF tested version of the victory-core library is older than the version that installs today. The newer version introduces a kinda breaking change in a minor release. Update: Fixed in 5.2.1 |
sjd78
added
the
do-not-merge/hold
sjd78
force-pushed
the
bump-pf-versions
branch
2 times, most recently
from
f06b7a4
to
d1ecebd
Compare
sjd78
removed
the
do-not-merge/hold
|
I have no idea why e2e-ui CI is failing here: Running locally the date selector looks and works correctly. |
Not sure - maybe a network timeout anomaly? |
|
@patternfly/[email protected] has the fix - not sure what the PF release schedule looks like apart from that. |
|
@sjd78 Looks like the fix made it to 5.2.3 https://github.com/patternfly/patternfly-react/releases/tag/5.2.3 |
rszwajko
added a commit
to rszwajko/tackle-ui-tests
that referenced
this pull request
Apr 10, 2024
1. the original motivation no longer applies as bug MTA-706 is fixed 2. providing the end date via date picker fails repeatedly with PatternFly 5.2 (it seems the start date pop-up is still detected in the DOM tree) Reference-Url: konveyor/tackle2-ui#1680 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
sjd78
force-pushed
the
bump-pf-versions
branch
2 times, most recently
from
81b3df2
to
817f914
Compare
|
Need to have konveyor/tackle-ui-tests#1069 merged before merging this PR. |
sjd78
added
the
do-not-merge/hold
Update to the 5.2 release of the patternfly libraries. See release notes https://www.patternfly.org/get-started/release-highlights/#patternfly-5.2 Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Bumped: @patternfly/react-code-editor @patternfly/react-core @patternfly/react-table Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
abrugaro
pushed a commit
to konveyor/tackle-ui-tests
that referenced
this pull request
Apr 22, 2024
* Type MigrationWave end date directly into the input 1. the original motivation no longer applies as bug MTA-706 is fixed 2. providing the end date via date picker fails repeatedly with PatternFly 5.2 (it seems the start date pop-up is still detected in the DOM tree) Reference-Url: konveyor/tackle2-ui#1680 Signed-off-by: Radoslaw Szwajkowski <[email protected]> * Type MigrationWave end date without delay Signed-off-by: Radoslaw Szwajkowski <[email protected]> --------- Signed-off-by: Radoslaw Szwajkowski <[email protected]>
sjd78
removed
the
do-not-merge/hold
ibolton336
approved these changes
Apr 22, 2024
rszwajko
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest 5.2.x releases of the patternfly libraries.
Changed the dependency version to specific pinned versions to be extra clear that we test and verify against exactly the versions in the
package.json.See release notes https://www.patternfly.org/get-started/release-highlights/#patternfly-5.2