Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type MigrationWave end date directly into the input #1069

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

rszwajko
Copy link
Contributor

  1. the original motivation no longer applies as bug MTA-706 is fixed
  2. providing the end date via date picker fails repeatedly with PatternFly 5.2 (it seems the start date pop-up is still detected in the DOM tree)

Reference-Url: konveyor/tackle2-ui#1680

1. the original motivation no longer applies as bug MTA-706 is fixed
2. providing the end date via date picker fails repeatedly with
   PatternFly 5.2 (it seems the start date pop-up is still detected in
   the DOM tree)

Reference-Url: konveyor/tackle2-ui#1680
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko
Copy link
Contributor Author

Hopefully it will unblock konveyor/tackle2-ui#1680

@rszwajko
Copy link
Contributor Author

@ibragins @nachandr @kpunwatk
please review (it seems I cannot add reviewers myself)

Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sshveta sshveta requested a review from abrugaro April 10, 2024 18:52
Copy link
Collaborator

@kpunwatk kpunwatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko
Copy link
Contributor Author

The original problem is solved, however now we see that the date is truncated(see screenshot from the CI below). It seems the type() command gets interrupted. It only occurs when running for konveyor/tackle2-ui#1680 in the GH actions (locally it's working).
The next attempt to solve it is to disable the delay used while typing and write the data (almost) at once.
Migration Waves CRUD operations -- Migration Wave CRUD (failed)

Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the PR @rszwajko.

@rszwajko
Copy link
Contributor Author

rszwajko commented Apr 22, 2024

@sshveta @abrugaro @kpunwatk
Can we merge this PR now? It blocks the merge for konveyor/tackle2-ui#1680

@abrugaro abrugaro merged commit be76d20 into konveyor:main Apr 22, 2024
7 checks passed
@abrugaro
Copy link
Collaborator

Hi @rszwajko,

Merged, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants