Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Gradle credentials enhancement #195

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Aug 7, 2024

Fixes #184

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle requested a review from jortel August 7, 2024 15:21
@dymurray dymurray added this to the v0.6.0 milestone Aug 20, 2024
@jmle jmle requested a review from jortel August 21, 2024 14:43
Copy link
Contributor

@rromannissen rromannissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- The analysis should succeed.
- The full list of dependencies should appear.

This can be compared with the analysis of the same application under its main branch, which uses Maven. They must be similar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: similar or the exact same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be the exact same

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a +1 once we add the test case plan

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle merged commit d14a0ca into konveyor:master Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Support credential files for Gradle projects
5 participants