-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NixOS support #70
base: master
Are you sure you want to change the base?
Conversation
@konkor I can do testing for non-NixOS distros in VM. Could you do some native testing? |
@balsoft Great job! You are really like your distro :) |
@konkor You're right! I've removed the rule from |
Fixed. Works on both gnome-shell 3.26.2 and 3.28. (NixOS 18.03 & NixOS 18.09). |
@balsoft notify-send works well after installing of ruby-notify package. |
@konkor I've switched to using async where possible. I believe it should work, as it works on at least 2 machines now. |
@konkor I understand that we have to use sync calls when we need the output. Amazingly though, when we need to be root, we don't need output and can use async calls. It's just a coincidence, but it works. |
@balsoft OK. Let me some time to check it all today. Don't change nothing more. I'm working on your branch now. |
@konkor Yes, it's asking for password every time you change some setting and also for some reason it asks for password a bunch of times on startup. I'm currently thinking of some kind of solution for that. We could have some sort of DBUS service that would elevate once on extension startup and then don't bother us anymore. That wouldn't be easy, though, as it is a potential security hole. |
@balsoft i think it's possible to add MD5 checksum of cpufreqctl to the PK rule to avoid modifying the script. |
@balsoft Well, here is what I found:
What do you think? |
@konkor Ok, thank you for spending the time on this.
|
This PR makes this extension work in NixOS, and presumably makes it work in any distro without installation. If user doesn't want to get prompted for every time they change settings, they need to install.
Stuff left to do: