Add sudo crate functionality #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsuyemoto
commented
May 3, 2023
gsuyemoto
commented
- Added sudo crate to Cargo.toml => sudo = "0.6"
- Modified main.rs to add sudo call at the very beginning of main()
- Removed call to function that checks for sudo privileges in main()
- Removed function for checking sudo privileges in utils.rs
- Removed use::std::env in utils.rs as the sudo function seemed to be the only code needing it
Use Rust starter workflow
…ing them an opportunity to escalate their privileges to root when running the app. This is in contrast to having the app exit and the user having the run the app again as sudo.
…d with sudo crate which automatically upgrades user privileges on app startup.
…est of the Cargo dependencies.
Saluki
requested changes
May 5, 2023
src/main.rs
Outdated
| // ---------------------------------------- | ||
| // Providing a prompt for the user when | ||
| // the app is run and user is not root | ||
| sudo::escalate_if_needed().expect("You need root permissions to run this app. Unable to escalate to sudo"); |
There was a problem hiding this comment.
Great @gsuyemoto ! A small change : the escalate_if_needed() call can be moved after the scan_options.request_protocol_print() condition (L48) in order to allow non-root users to view the protocol ASCII print and list the interfaces.
There was a problem hiding this comment.
Sure! I'll move the escalate, makes total sense!
src/utils.rs
Outdated
| * Based on the current UNIX environment, find if the process is run as root | ||
| * user. This approach only supports Linux-like systems (Ubuntu, Fedore, ...). | ||
| */ | ||
| pub fn is_root_user() -> bool { |
There was a problem hiding this comment.
Perfect, thanks for keeping the code base clean 👍
…rint() to allow users to use app for duties that do not require root access (e.g. view protocol ASCII print and list available interfaces).
|
Moved escalate. Added a short comment for network configuration line below it to help delineate from different logic. |
|
Hi @gsuyemoto 👋 Sorry for the delay - I want to merge your changes in the codebase but it looks like the Git history is not 100% clean (all files seems "changed"). Could you check in the "Files changed" tab what went wrong ? |
|
Hey Corentin!
Oh man, I haven't messed with this code in a while. I had actually added
Rust benchmarking and converted the ieee file to bincode and hashmap (for
my own use) for faster scanning (although slower loading). I should have
created a separate branch for the benchmarking/bincode/hashmap. I can take
a look at the admin rights upgrade to pull it out separately for a simpler
merge next week if that's cool.
…-Gary
On Wed, Aug 16, 2023 at 4:54 AM Corentin B. ***@***.***> wrote:
Hi @gsuyemoto <https://github.com/gsuyemoto> 👋 Sorry for the delay - I
want to merge your changes in the codebase but it looks like the Git
history is not 100% clean (all files seems "changed"). Could you check in
the "Files changed" tab what went wrong ?
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5S55YV6J3OPHNSSZM7PILXVSYHTANCNFSM6AAAAAAXVB3HVM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.