fix(STONEINTG-1087): retry longer to fetch App from ITS, and stop processing if not found #993
+32
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage ? 63.86%
=======================================
Files ? 49
Lines ? 6269
Branches ? 0
=======================================
Hits ? 4004
Misses ? 1908
Partials ? 357 ☔ View full report in Codecov by Sentry. |
dheerajodha
commented
Jan 20, 2025
dheerajodha
force-pushed
the
STONEINTG-1087
branch
2 times, most recently
from
cac7550 to
e2af425
Compare
dheerajodha
commented
Jan 27, 2025
dheerajodha
requested review from
hongweiliu17,
jsztuka,
Josh-Everett,
kasemAlem,
sonam1412,
14rcole and
jencull
as code owners
* There are some case where the App and ITS are created almost at the same time. This causes problem when the App is not found while the controllers reconcile ITS. * To fix this, we increased the retry time from 10 ms to 10 seconds. * This should give enough time to fetch the App. * And if we're still unable to find App, we stop reconciling, since there's no point in reconciling an ITS without any parent. Signed-off-by: Dheeraj<[email protected]>
* Now that we're checking for nil App within the scenario_controller.go file, * AND calling ContinueProcessing() in case of nil App, * AND marking the Scenario as Invalid in that case, * We don't need to check and do the same thing on scenario_adapter.go file as well, hence removing this code. Signed-off-by: Dheeraj<[email protected]>
* We should add Application to the logger, within the controller.go file rather than adapter.go file Signed-off-by: Dheeraj<[email protected]>
dheerajodha
force-pushed
the
STONEINTG-1087
branch
from
2fe1b82 to
6ea9ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section