Use custom renovate config maps for additional renovate options #391
+604
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rcerven
force-pushed
the
renovateoptions
branch
2 times, most recently
from
34ef12b to
db862a2
Compare
|
What is the "namespace one"? |
NamespaceWideRenovateConfigName = "namespace-wide-nudging-renovate-config" |
rcerven
force-pushed
the
renovateoptions
branch
from
db862a2 to
1cc182f
Compare
namespace one will be used if there isn't component's annotation with specific config map KONFLUX-4372 KONFLUX-4980 Signed-off-by: Robert Cerven <[email protected]>
rcerven
force-pushed
the
renovateoptions
branch
from
1cc182f to
a441fcd
Compare
chmeliik
reviewed
Jan 27, 2025
| Enabled: true, | ||
| FollowTag: buildResult.BuiltImageTag, | ||
| CommitMessagePrefix: target.ComponentCustomRenovateOptions.CommitMessagePrefix, | ||
| CommitMessageSuffix: fmt.Sprintf(", image created from '%s' \n %s", gitRepoAtShaAnnotation, target.ComponentCustomRenovateOptions.CommitMessageSuffix), |
There was a problem hiding this comment.
Cross-posting from Slack - can we break up the commit message to multiple lines to avoid breaking gitlint users? Something like this?
<Normal commit message>
Image created from:
<git repo @ commit sha>
There was a problem hiding this comment.
well renovate is ignoring even new line which I have there, I think it basically works just with single line commit
There was a problem hiding this comment.
Maybe we want CommitBody rather than CommitMessageSuffix? https://docs.renovatebot.com/configuration-templates/#commit-message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespace one will be used if there isn't component's annotation with specific config map
KONFLUX-4372
Checklist:
make testpasses