-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop obsolete scripts #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cm_generate_makefile and generate_makefile invoke CMake in fact.
Exercises/kokkoskernels/BlockJacobi/Begin/run_installlibs_cmake.sh
Outdated
Show resolved
Hide resolved
Exercises/kokkoskernels/BlockJacobi/Solution/run_installlibs_cmake.sh
Outdated
Show resolved
Hide resolved
@lucbv do you want to preserve these scripts? |
@ndellingwood can you have a look at this? |
@dalg24 your title says you are dropping obsolete scripts, can you mention somewhere on this PR what the replacement for these are? That would make the review a lot easier |
7576c25
to
712fda9
Compare
Withdrew the Kernels part and updated the description |
Then sure no problem from my side |
Yes, I never renamed the scripts to reflect they now internally use cmake, the naming is a carry-over from pre-cmake build system support (I think 3.0) and their usage in Jenkins builds From a glance, the scripts modified in this PR should still be functional and I would vote against their removal without some replacement directly calling cmake. In terms of the misleading naming of the {cm_}generate_makefile scripts, and their location in the resp. repos, I am overdue to do the following and will take care of this:
@dalg24 @lucbv let me know if you'd prefer to have the scripts in the PR updated after rename+reorg of generate_makefile etc. (fast and easy update), or if the preference is to have these scripts updated/replaced that directly call cmake (a bit more work) |
More cleanup, getting rid of makefile-based scripts
A couple scripts were to configure the AWS container which we have not used in 5y.
The other is supposed to be for updating the makefiles that we already removed.