Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disable clang-format in kp_json_writer.cpp #226

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

masterleinad
Copy link
Contributor

I don't see any good reason to disable clang-format in this file and enforcing the common formatting improves readability.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had done that when I introduced that new source file to keep the diff minimal with kp_reader.cpp. That was before we formatted all source files.

@dalg24 dalg24 merged commit 872352d into kokkos:develop Dec 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants