Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#65 Reorganize files, consistent CMake variables #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#65 Reorganize files, consistent CMake variables #66

wants to merge 1 commit into from

Conversation

Matthew-Whitlock
Copy link
Collaborator

@Matthew-Whitlock Matthew-Whitlock commented Jun 21, 2024 •
edited
Loading

Closes #65

  • Renamed ENABLE variables to all have a category (KR_ENABLE_VELOC_BACKEND, KR_ENABLE_MPI_CONTEXT, KR_ENABLE_STDFILE_DATA_SPACE).
  • All kr_option variables are automatically exposed as same-named preprocessor macro definitions when enabled
  • All kr_option variables are automatically exposed in resilienceConfig.cmake
  • StdFileBackend and StdFileContext now always enabled when automatic checkpoints are enabled. (A bit arbitrary, could be undone)
  • data_space/exec_space/backend directories (mostly because I get confused between the file-based space/backend/context)

@Matthew-Whitlock Matthew-Whitlock linked an issue Jun 21, 2024 that may be closed by this pull request
File structure and CMake/Preprocessor variable names are inconsistent #65
Open
@Matthew-Whitlock Matthew-Whitlock force-pushed the 65-file-structure-and-cmakepreprocessor-variable-names-are-inconsistent branch 3 times, most recently from 9f489fd to 1048987 Compare June 21, 2024 17:31
@Matthew-Whitlock Matthew-Whitlock requested a review from nmm0 June 21, 2024 22:13
@nmm0
Copy link
Contributor

nmm0 commented Nov 26, 2024

@Matthew-Whitlock can you rebase this and we can work to get it through

@Matthew-Whitlock Matthew-Whitlock force-pushed the 65-file-structure-and-cmakepreprocessor-variable-names-are-inconsistent branch from 1048987 to 8ebe3b5 Compare December 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmm0 nmm0 Awaiting requested review from nmm0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File structure and CMake/Preprocessor variable names are inconsistent
2 participants
@Matthew-Whitlock @nmm0