Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor serial tbsv implementation details and tests #2478

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Refactor serial tbsv implementation details and tests #2478

wants to merge 4 commits into from
+265 −180

Conversation

yasahi-hpc
Copy link
Contributor

This PR aims at improving the implementation and testing of serial tbsv.

  • Moving implementation details into Impl namespace.
  • Use OpID and OpConj for conj operations instead of do_conj variable
  • Use Kokkos::is_view_v<AViewType> instead of Kokkos::is_view<AViewType>::value
  • Covering all the unit-tests for all the combinations of Non-Trans/Trans/ConjTrans
  • Remove using namespace KokkosBatched from the test code
  • Rename variables starting from underscores in the test code

@cwpearson cwpearson added the AT2-CI-APPROVAL Approve CI to run at SNL label Jan 13, 2025
@yasahi-hpc yasahi-hpc mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AT2-CI-APPROVAL Approve CI to run at SNL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasahi-hpc @cwpearson