[4.4.01] Patches to 4.4.01 #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If building KokkosKernels standalone, leave int as the default offset (this was the case since kokkos#2140). But if building KokkosKernels as a Trilinos/Tribits package, then make size_t the default offset because this is what the Tpetra stack currently uses. Signed-off-by: Brian Kelley <[email protected]>
* CRS sorting improvements - Wrote bulk sort/permutation based sorting for CRS graph, matrix, and BSR matrix (bulk = one large sort of all the entries, using row-major dense index as keys) - This is more performant for imbalanced entries per row - If matrix dimensions are too large to do bulk sort, fall back to sorting within each row with a thread. * Add perf test for sort_crs_matrix * sort_crs: improve parallel labels * Work around kokkos issue 7036 * sort_crs: replace radix sort lambda with functor (Lambda segfaults with nvcc+openmp) --------- Signed-off-by: Brian Kelley <[email protected]>
SpAdd handle was originally a copy-paste of the spgemm handle way back in kokkos#122, and included get_sort_option() and set_sort_option() from spgemm. But these try to use the member bool sort_option, which doesn't exist. Somehow these functions never produced compile errors until someone tried to call them.
|
Noting that AT2 jobs will not run due to block on external user contributions, this does not indicate test failure @lucbv was this changed in any of the recent AT2 updates, and if so should I pull those in with this PR? |
|
Yes, this was changed in PR #2320 and we can pull it in since it only affects github actions so it is transparent to users : ) |
lucbv
approved these changes
Sep 5, 2024
|
Supposedly having me approve and re-run the jobs should have allowed the tests to run @e10harvey do you know why it would fail to run in this case? |
|
@lucbv setting the nightly Trilinos integration builds to test with this PR ran fine, including Hip, Cuda, Sycl (Tpetra tests only), OpenMP backends. Should be safe for merge |
lucbv
added
AT2-SPECIAL-APPROVAL
ndellingwood
merged commit 336ee5f
into
kokkos:release-candidate-4.4.01
9 checks passed
lucbv
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Set version number to 4.4.01 * [4.4.01] Patches to 4.4.01 (#2327) * Restore size_t as default offset, in Tribits builds (#2313) If building KokkosKernels standalone, leave int as the default offset (this was the case since #2140). But if building KokkosKernels as a Trilinos/Tribits package, then make size_t the default offset because this is what the Tpetra stack currently uses. Signed-off-by: Brian Kelley <[email protected]> * Improve crs/bsr sorting performance (#2293) * CRS sorting improvements - Wrote bulk sort/permutation based sorting for CRS graph, matrix, and BSR matrix (bulk = one large sort of all the entries, using row-major dense index as keys) - This is more performant for imbalanced entries per row - If matrix dimensions are too large to do bulk sort, fall back to sorting within each row with a thread. * Add perf test for sort_crs_matrix * sort_crs: improve parallel labels * Work around kokkos issue 7036 * sort_crs: replace radix sort lambda with functor (Lambda segfaults with nvcc+openmp) --------- Signed-off-by: Brian Kelley <[email protected]> * SpAdd handle: delete sort_option getter/setter (#2296) SpAdd handle was originally a copy-paste of the spgemm handle way back in #122, and included get_sort_option() and set_sort_option() from spgemm. But these try to use the member bool sort_option, which doesn't exist. Somehow these functions never produced compile errors until someone tried to call them. * Improve GH action to produce release artifacts (#2312) * coo2csr: add parens to function calls (#2318) * Update changelog * Update master_history.txt * .github/workflows: Group jobs under common github-AT2 name (#2320) * Update master_history.txt --------- Signed-off-by: Brian Kelley <[email protected]> Co-authored-by: brian-kelley <[email protected]> Co-authored-by: Damien L-G <[email protected]> Co-authored-by: Carl Pearson <[email protected]> Co-authored-by: Evan Harvey <[email protected]> * Update master_history.txt for 4.4.01 --------- Signed-off-by: Brian Kelley <[email protected]> Co-authored-by: brian-kelley <[email protected]> Co-authored-by: Damien L-G <[email protected]> Co-authored-by: Carl Pearson <[email protected]> Co-authored-by: Evan Harvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.