[4.4.00] Cherry-pick PRs 2281 and 2297 #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ndellingwood
commented
Aug 7, 2024
ndellingwood
commented
- Add support for BSRs to sptrsv (Add support for BSRs to sptrsv #2281)
- Some compilers throw shadow warnings in static functions (Some compilers throw shadow warnings in static functions #2297)
* Some cleanup and refactoring * First round of cleanup complete * Fix a couple warnings * formatting * Cleanup progress * Fixes * Remove Upper/Lower TriLvlSchedTP2SolverFunctors * Remove Upper/Lower single block functors * Remove unused TriLvlSchedTP1SingleBlockFunctorDiagValues and merge upper/lower tri_solve_cg * Merge two big upper/lower branch of tri_solve_chain * Merge upper/lower tri_solve_streams * progres * progress * Progress, test added * progress and fixes * prog * prog but broken * Prog with debug prints * Remove extreme debug printing * works * all working * Remove test mangling * Switch over block spiluk precond test to use new block sptrsv * More test cleanup * Fixes for GPU warnings * Conflicts resolved, still work needed * builds * Formatting * Update work to latest format style * Remove unused functions. Remove prints. Add barriers * Minor fixes * lset is not used * Fix for clang * formatting * New impl approach * Unset macro * There's no reason to limit team-policy alg to MAX_VEC_SIZE * formatting * Add missing kokkos-inline-funcs * Fix warnings * format
jgfouca
approved these changes
Aug 7, 2024
|
I don't understand why three of the jobs were cancelled , maybe adding a review triggered something in AT2? @lucbv ? |
|
The jobs that were cancelled after the review submission had matching configuration jobs with extra label |
|
Cancelled jobs were superceded by those with the modified |
ndellingwood
merged commit 418e2fa
into
kokkos:release-candidate-4.4.00
9 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.