Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.3.01 #2197

Merged
merged 20 commits into from
May 8, 2024
Merged

Conversation

ndellingwood
Copy link
Contributor

No description provided.

ndellingwood and others added 17 commits April 25, 2024 11:44
* Progress

* Attempt 1, fix multiplication order

* Converges in 1 step

* Various cleanups

* Be sure not to reduce performance of unblocked impl

Also add some comments.

* Remove test mangling

* Fixes for GPU

* Fix warning

* formatting

* Increase eps for floats

* This is no longer needed
Add guard for cusparse spmv_mv_tpl_spec_avail

(cherry picked from commit cb824ca)
…x-divide-by-zero-in-trsv

Add early return if numRows == 0 in trsv to avoid integer divide-by-zero error

(cherry picked from commit 83374bf)
* magma: fix linker errors for builds without cusolver

* BatchedGemm test: workaround testing cublas+magma

- temporary workaround to skip magma test when cublas enabled to avoid issues like kokkos#2177
… symbol (kokkos#2183)

Stick to pattern of removing leading 'c' or 'z' in method name and relying on the template type

Co-authored-by: malphil <[email protected]>
spmv: add special path for rank-2 x/y, but where both have 1 column
and a TPL is available for rank-1 but not rank-2.

Also call "subhandle->set_exec_space" correctly in the TPLs to ensure
proper synchronization between setup, spmv and cleanup (in the case that
different exec instances are used in different calls)
workflows/osx.yml: test against most recent kokkos tag

(cherry picked from commit c099cea)
* Fix docs build

* try docs fix

* make sphinx available at config time
Part of Kokkos C++ Performance Portability Programming EcoSystem 4.3
@ndellingwood
Copy link
Contributor Author

Hold until confirmation of passing status of Trilinos snapshot PR trilinos/Trilinos#12995

@ndellingwood ndellingwood force-pushed the master-release-4.3.01 branch from 54f68d0 to 2ce7a40 Compare May 7, 2024 18:34
@ndellingwood ndellingwood force-pushed the master-release-4.3.01 branch from 2ce7a40 to 3939ace Compare May 7, 2024 18:36
@ndellingwood
Copy link
Contributor Author

Needed a fix for the version check and changelog fix ca09900 (thanks @brian-kelley !); rebased and cleaned up the the branch, along with updated snapshot to Trilinos

@ndellingwood
Copy link
Contributor Author

docs-check is attempting test against kokkos@develop (i.e. 4.3.99), outside of the range of supported versions by the patch release; will update the check (on develop branch) to test against most recent kokkos release

@ndellingwood
Copy link
Contributor Author

PR trilinos/Trilinos#12995 passed AT checks

Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks fine to me

@ndellingwood ndellingwood merged commit d1a91b8 into kokkos:master May 8, 2024
6 of 7 checks passed
@ndellingwood ndellingwood deleted the master-release-4.3.01 branch May 8, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants