Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI #44

Merged
merged 13 commits into from
Feb 9, 2024
Merged

Improve CI #44

merged 13 commits into from
Feb 9, 2024

Conversation

pzehner
Copy link
Collaborator

@pzehner pzehner commented Feb 8, 2024 •
edited
Loading

This PR aims to improve the CI workflow by the following elements:

  • Rename images after their compiler environment, and explicitly use their name (rather than relying on backend name);
  • Increase tests verbosity in case of failure (as CTest only shows outcomes by default);
  • Rebuild base images on pushes on the main branch if Docker images were modified;
  • Use tags for base images: main images are always tagged latest and PR images are tagged with their commit hash; and
  • Update ROCM image (remove tag that was introduced by mistake).

Post-merge actions:

  • Remove images with old names.

@pzehner pzehner added the enhancement New feature or request label Feb 8, 2024
@pzehner pzehner self-assigned this Feb 8, 2024
@pzehner pzehner requested a review from yasahi-hpc February 9, 2024 14:29
@pzehner pzehner marked this pull request as ready for review February 9, 2024 14:29
yasahi-hpc
yasahi-hpc approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR helps to introduce threads backend. Thanks a lot!
The image names may be changed in the future.

.github/workflows/build_test.yaml
c_compiler: gcc
cxx_compiler: g++
cmake_flags: -DKokkos_ENABLE_CUDA=ON -DKokkos_ARCH_AMPERE80=ON
- name: hip
image: rocm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may prefer to call this image hipcc.

.github/workflows/build_test.yaml
c_compiler: hipcc
cxx_compiler: hipcc
cmake_flags: -DKokkos_ENABLE_HIP=ON -DKokkos_ARCH_VEGA90A=ON
- name: sycl
image: intel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well, better to call this image dpcpp?

@yasahi-hpc yasahi-hpc merged commit 03f8a3a into main Feb 9, 2024
16 checks passed
@yasahi-hpc yasahi-hpc deleted the feature/improve-ci branch February 9, 2024 14:47
@pzehner pzehner mentioned this pull request Feb 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricchevalier19 cedricchevalier19 cedricchevalier19 left review comments

@yasahi-hpc yasahi-hpc yasahi-hpc approved these changes

Assignees

@pzehner pzehner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pzehner @cedricchevalier19 @yasahi-hpc