-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doxygen #42
Add doxygen #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great documentation effort! This looks great to me.
file(MAKE_DIRECTORY ${DOXYGEN_OUTPUT_DIR}) | ||
|
||
# Only regenerate Doxygen when the Doxyfile or public headers change | ||
add_custom_command(OUTPUT ${DOXYGEN_INDEX_FILE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use doxygen_add_docs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not notice this command. Seems simpler.
docs/Makefile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a Makefile needed in addition to cmake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for sphinx, and in the end, we do not rely on CMake in the rtd workflow.
docs/conf.py
Outdated
# sys.path.insert(0, os.path.abspath('.')) | ||
import subprocess, os | ||
|
||
def configureDoxyfile(input_dir, output_dir, doxyfile_in, doxyfile_out): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this same functionality is present in CMake, why is there a duplication?
doxyfile_in = cwd + '/Doxyfile.in' | ||
doxyfile_out = cwd + '/Doxyfile' | ||
configureDoxyfile(input_dir, output_dir, doxyfile_in, doxyfile_out) | ||
subprocess.call('pwd; ls -lat; doxygen Doxyfile; ls -lat doxygen/xml', shell=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here again I don't understand, does CMake handle Doxygen call or python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the rtd workflow, only the python works. CMake is not used.
extents_type m_in_extents, m_out_extents; | ||
|
||
// Only used when transpose needed | ||
//! Internal buffers used for transpose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without @{
@}
, you only comment the first next variable m_in_T
, not the following one m_out_T
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we need the comment like this?
//@{ //! Internal buffers used for transpose @}//
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not exactly, the @{
and @}
should surround the variables, see https://www.doxygen.nl/manual/grouping.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So,
///@{
//! extents of input/output views
extents_type m_in_extents, m_out_extents;
///@}
//! Internal buffers used for transpose | ||
nonConstInViewType m_in_T; | ||
nonConstOutViewType m_out_T; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//! Internal buffers used for transpose | |
nonConstInViewType m_in_T; | |
nonConstOutViewType m_out_T; | |
//! @{ | |
//! Internal buffers used for transpose | |
nonConstInViewType m_in_T; | |
nonConstOutViewType m_out_T; | |
//! @} |
In this PR, I have added a template for documentation with doxygen + sphinx. Workflow may be added based on this PR.