-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CMake installation in Dockerfiles #222
Conversation
@yasahi-hpc Please propagate the Clang Dockerfile modification to the other ones. |
Thanks! |
Shouldn't we use the same CMake version everywhere? By the way, I should document how to get this damn key. |
That is nice! Actually, oneAPI says they recommend CMake 3.25 as minimum. |
I added some documentation. Could you use it and check if it's understandable? |
Thanks. It is good. I just added an URL of CMake 3.23.2 as an example |
@pzehner May I have another review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with it.
I differentiated the two document files because one is intended for maintenance. But if you want to merge the two files into one, feel free. |
@pzehner Thank you for your review. Let me merge files. |
I should have added [ci skip]. In the CI, we encountered the error related to the permission. Can I fix the permission issue in this PR? @pzehner |
242b5a5
to
4c8402e
Compare
Seems OK now. I will merge this. Thank you for your help @pzehner |
Fixes CI failures due to the build failure of clang Dockerfile. (See build failure)