Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to continue run tests even if ruche CI fails #193

Merged

Conversation

yasahi-hpc
Copy link
Collaborator

In this RP, we allow to continue run tests even if ruche CI fails.

@yasahi-hpc yasahi-hpc self-assigned this Nov 4, 2024
@yasahi-hpc yasahi-hpc added enhancement New feature or request CI labels Nov 4, 2024
@yasahi-hpc yasahi-hpc marked this pull request as draft November 4, 2024 15:20
@tpadioleau
Copy link
Member

I still think it is worth it, we should try to make it work at some point

@yasahi-hpc
Copy link
Collaborator Author

I still think it is worth it, we should try to make it work at some point

I agree. I will fix this soon

@yasahi-hpc yasahi-hpc force-pushed the make-ruche-ci-to-continue-on-error branch from 57cf7ea to c0b5f11 Compare January 3, 2025 00:45
@yasahi-hpc yasahi-hpc marked this pull request as ready for review January 6, 2025 09:57
.github/workflows/build_test.yaml Outdated Show resolved Hide resolved
.github/workflows/build_test.yaml Show resolved Hide resolved
@yasahi-hpc yasahi-hpc force-pushed the make-ruche-ci-to-continue-on-error branch from a521375 to b9b3f08 Compare January 8, 2025 09:38
@yasahi-hpc yasahi-hpc force-pushed the make-ruche-ci-to-continue-on-error branch from ad95823 to 26336e6 Compare January 8, 2025 10:41
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's try!

@yasahi-hpc
Copy link
Collaborator Author

@tpadioleau Thanks again for the review.
Fortunately or unfortunately, ruche CI worked this time.
Hopefully after merging this, CI continues even if ruche CI fails

@yasahi-hpc yasahi-hpc merged commit d991b0c into kokkos:main Jan 8, 2025
20 checks passed
@yasahi-hpc yasahi-hpc deleted the make-ruche-ci-to-continue-on-error branch January 8, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants