Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

std::pair has .first and .second #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std::pair has .first and .second #69

wants to merge 1 commit into from

Conversation

keryell
Copy link
Contributor

@keryell keryell commented Aug 7, 2018

And not .begin and .end.

@keryell
std::pair has .first and .second
8707b38 
And not .begin and .end.
dhollman
dhollman approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@dhollman dhollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but this implementation is no longer maintained. Please see github.com/kokkos/mdspan for the current implementation

@keryell
Copy link
Contributor Author

keryell commented Jun 18, 2020

Approving this, but this implementation is no longer maintained. Please see github.com/kokkos/mdspan for the current implementation

Thanks.
Actually I switched to the new implementation a few months ago and it seems to work with the SYCL implementation I am working on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhollman dhollman dhollman approved these changes

@dsunder dsunder Awaiting requested review from dsunder

@crtrott crtrott Awaiting requested review from crtrott

@mhoemmen mhoemmen Awaiting requested review from mhoemmen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keryell @dhollman