Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add deploy script #120

Merged
merged 2 commits into from
Nov 16, 2023
Merged

build: add deploy script #120

merged 2 commits into from
Nov 16, 2023

Conversation

shigma
Copy link
Member

@shigma shigma commented Nov 13, 2023 •
edited
Loading

  • Add a deploy job
  • Upgrade workflow actions
  • Update search index

@MaikoTan
Copy link
Member

MaikoTan commented Nov 14, 2023 •
edited
Loading

  • Deploy job should only take effect when pushing to master

Consider use the if condition?

  if: github.ref == 'refs/head/main'

@shigma
Copy link
Member Author

shigma commented Nov 14, 2023

Consider use the if condition?

  if: github.ref == 'refs/head/main'

I would prefer use a separate deploy.yml workflow. I'll do it later.

@shigma shigma requested a review from MaikoTan November 14, 2023 18:25
@shigma shigma marked this pull request as ready for review November 14, 2023 18:25
MaikoTan
MaikoTan approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@MaikoTan MaikoTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno why the CI failed, but it looks good to me.

@MaikoTan MaikoTan merged commit f6074d3 into main Nov 16, 2023
1 of 3 checks passed
@MaikoTan MaikoTan deleted the deploy branch November 16, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaikoTan MaikoTan MaikoTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shigma @MaikoTan