Add hotswapping to FromHost and ToHost elements #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. But please describe what it does in the commit messages (and in the pull request if it's multiple commits). |
shlomos
force-pushed
the
master
branch
3 times, most recently
from
4117b6c
to
8d685fc
Compare
FromHost initiates a tap device which is used to pass packets to the kernel network stack handling. ToHost uses the tap's fd opened be FromHost. As it was, when sending a new config to click having when the previous had a FromHost element, would fail as the tap device is busy. Hotswapping support enables to send click a hotconfig which forces the new FromHost(and ToHost) to take state from the swapped elements, thus continuing proper packet handling. When adding hotswap support to FromHost, ToHost must also support hotswap as it searches on initialization an existing and initialized FromHost element to take it fd. Signed-off-by: Shlomo Shenzis <[email protected]>
|
Done. Removed all changes to blanks and added a description in the commit message. |
|
@tbarbette: Anything missing? |
|
I do not handle non-DPDK related merges to mainline. If you feel like it you can open a PR to FastClick, I would merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomo Shenzis [email protected]