Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid type error on systems with HAVE_VA_LIST_AS_ARRAY #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix invalid type error on systems with HAVE_VA_LIST_AS_ARRAY #340

wants to merge 1 commit into from

Conversation

asmuth
Copy link
Contributor

@asmuth asmuth commented Apr 5, 2017

fixes #336

@kohler
Copy link
Owner

kohler commented Jun 28, 2017

I'm confused. Where does HAVE_VA_LIST_AS_ARRAY come from? It's not something we define.

I'm worried that the type error actually represents a problem.

@kohler
Copy link
Owner

kohler commented Jun 28, 2017

The CLICK_CHECK_ADDRESSABLE_VA_LIST configury step is supposed to detect this problem, and then leave HAVE_ADDRESSABLE_VA_LIST undefined.

@asmuth
Copy link
Contributor Author

asmuth commented Jun 28, 2017

The problem came up a while back when trying to build click inside of a bitbake/yocto toolchain.

I did not realize there was already a check for this condition and added the HAVE_VA_LIST_AS_ARRAY ifdef (which seemed semi-standard, at least mozilla central and rpm use it) as a quick local patch and built with -DHAVE_VA_LIST_AS_ARRAY to work around the issue.

Of course if there already is a proper configure-time check for this, that should be used instead. I'll try debugging later/tomorrow why the CLICK_CHECK_ADDRESSABLE_VA_LIST did not work as intended inside of our cross toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while cross-compiling clkmindriver
3 participants