[PlaylistLoader] Fix KODIPROP parsing #889
Conversation
kodi props must be read in full without use delimiters that break the string at first space or double accents " otherwise lead to broken properties values
|
Same as last time. If you want this released please add a changelog and update the addon xml. |
|
done, add also backport pr |
|
@phunkyfish can you merge and release? this and backport? |
| @@ -1,3 +1,6 @@ | |||
| v22.1.2 | |||
| - Fix #KODIPROP parsing from playlists | |||
|
|
|||
There was a problem hiding this comment.
Is Fix wrong fix to manifest user-agent header for inputstream.adaptive missing from changelog / commits? Or is it not required for Piers branch?
There was a problem hiding this comment.
piers its ok, it is only on omega that i accidentally cherry-picked the old commit without realizing it
There was a problem hiding this comment.
Ok, so any change needed for Omega?
There was a problem hiding this comment.
you have already merged the omega backport that contains reverted "bad" commit and applied the correct one
so now omega its ok
Sure, but there is a missing commit in this PR and I couldn't tell if it was required or not. |
kodi props
#KODIPROPmust be read in fullso without use delimiters that break the string
at first space or double accents " otherwise lead to broken properties values
fix #887
fix xbmc/inputstream.adaptive#811 (comment)
backport needed
i add version bump commit after review