-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TimeField component #529
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for kobalte pending review.Visit the deploys page to approve it
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, mostly looks good!
Small changes required;
The time zone segment shouldn't be interactive since we can change it.
AM
should be the last highlighted item when you move right.
For arrow interaction the min and max should probably not inc/decrement when out of bounds. The warning should only appear if an invalid time is manually typed.
Placeholder doesn't seem to work (W11 FF 132.0.2):
Lastly the hidden input should follow changes to it, this is done to allow browser form autofill and cache. More info below.
Hey Jeremy, thanks for the review!
When you increment the hour, it doesn’t start at 9? |
Yeah it does, I still think it would be good to also make it display the placeholder in gray (and become a value on first interact). |
This PR adds a new TimeField component.
Closes #317