Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting DB types for USERDATA table to start addressing issue #94 #214

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Adjusting DB types for USERDATA table to start addressing issue #94 #214

merged 3 commits into from
Apr 30, 2024

Conversation

srmeier
Copy link
Contributor

@srmeier srmeier commented Mar 27, 2024

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the canary branch (left side). Also you should start your branch off our canary.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Description

This PR is in combination with this PR against the ko-db repo. It updates the SQL types to binary and allows for the user to save their character information (tested locally). This is a small piece of issue #94.

💔Thank you!

@srmeier srmeier requested a review from stevewgr March 27, 2024 20:51
@srmeier srmeier self-assigned this Mar 27, 2024
@srmeier srmeier mentioned this pull request Mar 27, 2024
Merged
@stevewgr
Copy link
Member

As also mentioned on discord, sorry for keeping this on hold for some time. I was away and now reworking the ko-db project so that I can hopefully by tomorrow rebase your PRs and merge them.
The changes works as intended 👍 Thanks for submitting it.

srmeier and others added 3 commits April 30, 2024 02:11
@srmeier @stevewgr
Adapt database changes for binary columns.
70966f7 
Now character data will be properly saved.

@srmeier:
+ Update variable name to reflect datatype
+ Adjusting DB dtypes for USERDATA table to start addressing issue #94
@stevewgr
Remove comments for test tables that has been removed.
9f5593d
@stevewgr
Fixate ko-db version to 1.0.0.
c103122
@stevewgr stevewgr force-pushed the adjust-userdata-db-types branch from d0e49b8 to c103122 Compare April 30, 2024 06:14
@stevewgr stevewgr marked this pull request as draft April 30, 2024 06:16
@stevewgr stevewgr marked this pull request as ready for review April 30, 2024 06:16
@stevewgr stevewgr self-assigned this Apr 30, 2024
stevewgr
stevewgr approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@stevewgr stevewgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build passing: https://github.com/ko4life-net/ko/actions/runs/8890180501/job/24409775145

Thank you @srmeier! It is time for shipping.
image

@stevewgr stevewgr merged commit 0be3fd0 into master Apr 30, 2024
2 checks passed
@stevewgr stevewgr deleted the adjust-userdata-db-types branch April 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevewgr stevewgr stevewgr approved these changes

Assignees

@srmeier srmeier

@stevewgr stevewgr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srmeier @stevewgr