Enable Compilation on JDK21 #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. |
rvullriede
force-pushed
the
fix/jdk-21-support
branch
from
8af1804 to
1e2bb2f
Compare
|
@rizer1980, sorry that was unintentional. I'll cleaned this up. In addition, I noticed that meanwhile the problematic lombok dependency was updated already. What remains are the more robust compilation settings. |
|
How about changing the code level to 11? Since we're anyway building witth SDK 11. What do you think, @timmolter ? |
|
@bigscoop ok, let's try it after the next release (coming this week). That way Java 11 will be present in the SNAPSHOT versions for a while before releasing it. We've tried several times in the past, but people reported issues with Android. Maybe it will work out this time around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used lombok version is not compatible with JDK 21.
In addition, Its advised to switch from source/target to release (see https://openjdk.org/jeps/247 for details), introduced in Java 9.
The maven compiler plugin with translate this automatically to the old source/target/bootclasspath options for Java 8 compilers.