Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Compose V2 #5

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Switch to Compose V2 #5

merged 2 commits into from
Jul 28, 2024

Conversation

jnk0
Copy link
Contributor

@jnk0 jnk0 commented Apr 28, 2024

Docker Compose V1 has stopped receiving updates [1] and should be replaced by V2. This PR aims to migrate to V2.

[1] https://docs.docker.com/compose/

@knoppi
Copy link
Owner

knoppi commented Apr 29, 2024

I think this is an improvement. Just a question: how would you ensure compose v2 is installed using puppet? Since it is a prerequisite now, we should tackle this.

Currently the inclusion of docker makes this class self consistent, but it will not provide compose v2.

@knoppi
Copy link
Owner

knoppi commented May 15, 2024

Do you have any update on this? (And I edited my last post. A 'not' was missing which spoilt the whole sentence.)

@jnk0
Copy link
Contributor Author

jnk0 commented Jul 5, 2024

It may not be necessary to force it. The Docker module now takes care of this (PR#975), and newer versions of Docker simply don't support Compose v1 anymore.

@knoppi
Copy link
Owner

knoppi commented Jul 22, 2024

Can you please update the metadata to contain docker >= 10.0.0 < 11.0.0?

There are other issues with the metadata that I will have a look at at another point.

@jnk0
Copy link
Contributor Author

jnk0 commented Jul 23, 2024

I have updated the dependency on the puppetlabs-docker module.

@knoppi knoppi merged commit c22b8e0 into knoppi:develop Jul 28, 2024
@knoppi
Copy link
Owner

knoppi commented Jul 28, 2024

Thanks for your contribution. I will finalize a new release soon and publish it on Puppet Forge.

@knoppi
Copy link
Owner

knoppi commented Aug 7, 2024

@jnk0 Your changes are available in version 2.0.0 of the module available on Puppet forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants